[webkit-reviews] review granted: [Bug 52085] Add Document::setContent() : [Attachment 78593] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 52085: Add Document::setContent()
https://bugs.webkit.org/show_bug.cgi?id=52085

Attachment 78593: Patch
https://bugs.webkit.org/attachment.cgi?id=78593&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78593&action=review

LGTM.

> Source/WebCore/loader/cache/CachedFont.cpp:143
> +	   m_externalSVGDocument->setContent(decoder->decode(m_data->data(),
m_data->size()) + decoder->flush());

It's unfortunate that this is much less memory efficient now.  We end up doing
two (possibly large) allocations for the main data decoding instead of one.