[webkit-reviews] review granted: [Bug 52229] Enforce READ_ONLY transactions in IndexedDB : [Attachment 78565] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 52229: Enforce READ_ONLY transactions in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=52229

Attachment 78565: Patch
https://bugs.webkit.org/attachment.cgi?id=78565&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78565&action=review

The tests have huge diffs for no visible reason, so I'm assuming the line
endings changed.  Are they right before or after this patch?

> Source/WebCore/storage/IDBCursorBackendImpl.cpp:169
>  
> -    // FIXME: Check that the transaction is READ_WRITE
> -    // if (m_transaction->mode() == IDBTransaction::READ_ONLY) {
> -	   // FIXME: We must return READ_ONLY_ERR here. Fix this when we update
IDBDatabaseException to match the spec.
> -	   // ec = IDBDatabaseException::NOT_ALLOWED_ERR;
> -	   // return;
> -    // }
> +

Looks like two lines of whitespace here.