[webkit-reviews] review denied: [Bug 52085] Add Document::setContent() : [Attachment 78547] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 52085: Add Document::setContent()
https://bugs.webkit.org/show_bug.cgi?id=52085

Attachment 78547: Patch
https://bugs.webkit.org/attachment.cgi?id=78547&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78547&action=review

> Source/WebCore/dom/Document.cpp:1179
> +    return wellFormed();

I feel like well-formedness has little to do with if the setContent succeeded
or not, which is what the bool return from setContent feels like it should be.

It seems the callers should check wellFormed separately.

> Source/WebCore/loader/cache/CachedFont.cpp:144
> +
> +	   if
(!m_externalSVGDocument->setContent(decoder->decode(m_data->data(),
m_data->size()) + decoder->flush()))
> +	       m_externalSVGDocument = 0;

This is wrong.

You got rid of the decoder error detection.  If we don't have a test for that,
we should.