[webkit-reviews] review granted: [Bug 25614] ASSERTION Failure in JSC::binaryChop : [Attachment 78541] Patch to use Proper PC value for Stack Overflow Exception Processing

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 25614: ASSERTION Failure in JSC::binaryChop
https://bugs.webkit.org/show_bug.cgi?id=25614

Attachment 78541: Patch to use Proper PC value for Stack Overflow Exception
Processing
https://bugs.webkit.org/attachment.cgi?id=78541&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78541&action=review

r=me

It's fine to make the small change I mentioned and check in without an
additional round of review.

> Source/JavaScriptCore/jit/JIT.cpp:509
> +	   JITStubCall(this, m_codeBlock->m_isConstructor ?
cti_op_construct_arityCheck : cti_op_call_arityCheck).call();
> +
>	   move(regT0, callFrameRegister);

A shorter way to do this is to pass callFrameRegister as the argument to
JITStubCall::call(), and remove the explicit call to move(). The argument to
JITStubCall::call() specifies where you'd like the return value to be stored.