[webkit-reviews] review denied: [Bug 50867] [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6 : [Attachment 78359] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 11 09:04:52 PST 2011
Martin Robinson <mrobinson at webkit.org> has denied Koan-Sin Tan
<koansin.tan at gmail.com>'s request for review:
Bug 50867: [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50867
Attachment 78359: proposed patch
https://bugs.webkit.org/attachment.cgi?id=78359&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78359&action=review
Looks good, but I think there is a remaining issue below.
> Source/WebCore/platform/UUID.cpp:74
> -#elif OS(DARWIN)
> +elif OS(DARWIN) && PLATFORM(CF)
I don't think it's right here to remove the #
More information about the webkit-reviews
mailing list