[webkit-reviews] review denied: [Bug 37394] inspector/timeline-network-resource.html fails when run twice : [Attachment 78529] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 37394: inspector/timeline-network-resource.html fails when run twice
https://bugs.webkit.org/show_bug.cgi?id=37394

Attachment 78529: Patch
https://bugs.webkit.org/attachment.cgi?id=78529&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78529&action=review

> Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:51
> +    m_inspectorController->didReceiveResponse(identifier, response);

You should call InspectorInstrumentation::didReceiveResponse (here and in other
places).

> Source/WebCore/inspector/InspectorController.h:162
> +    void didReceiveResponse(unsigned long identifier, const
ResourceResponse&);

Make this private as well.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:443
> +    ic->didReceiveResponse(identifier, response);

Add // FIXME: move this to console agent.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:464
> +    ic->didFailLoading(identifier, error);

ditto

> Source/WebCore/inspector/front-end/NetworkManager.js:-228
> -		   mainResource.isMainResource = true;

You will need to rebaseline this.

> WebKit/chromium/src/WebDevToolsAgentImpl.cpp:295
> +	   InspectorInstrumentation::willSendRequest(mainFrame(), resourceId,
request.toMutableResourceRequest(), ResourceResponse());

mainFrame will be used by the InspectorResourceAgent and plugin resources will
belong to the wrong node in the frame tree.