[webkit-reviews] review granted: [Bug 51751] Web Inspector: recreate script view after live edit : [Attachment 77684] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 11 04:39:14 PST 2011


Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 51751: Web Inspector: recreate script view after live edit
https://bugs.webkit.org/show_bug.cgi?id=51751

Attachment 77684: Patch.
https://bugs.webkit.org/attachment.cgi?id=77684&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77684&action=review

> WebCore/inspector/front-end/ScriptsPanel.js:316
> +		       script.resource.setContent(newBodyOrErrorMessage,
revertEditingCallback);

In the future, we'd like to edit inline script of say HTML resources. As a
result, committing snippet content as resource content will become wrong.


More information about the webkit-reviews mailing list