[webkit-reviews] review denied: [Bug 51528] [v8] ScriptController::evaluate returns empty result for undefined. Can't distinguish errors from undefined results. : [Attachment 77331] fix, allow the "undefined" v8 object to be returned

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 11 03:08:48 PST 2011


Eric Seidel <eric at webkit.org> has denied  review:
Bug 51528: [v8] ScriptController::evaluate returns empty result for undefined.
Can't distinguish errors from undefined results.
https://bugs.webkit.org/show_bug.cgi?id=51528

Attachment 77331: fix, allow the "undefined" v8 object to be returned
https://bugs.webkit.org/attachment.cgi?id=77331&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This patch was not created correctly.  Please create from a WebKit checkout. 
Also, all patches require a ChangeLog.

webkit-patch upload

will walk you through much of this.


More information about the webkit-reviews mailing list