[webkit-reviews] review granted: [Bug 52197] Use definition of PI from MathExtras.h : [Attachment 78497] This patch uses the standard definitions of PI from MathExtras.h

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Carl Lobo <carllobo at gmail.com>'s
request for review:
Bug 52197: Use definition of PI from MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=52197

Attachment 78497: This patch uses the standard definitions of PI from
MathExtras.h
https://bugs.webkit.org/attachment.cgi?id=78497&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78497&action=review

Looks great.  But we need to fix the ChangeLog first or the commit-queue will
fail to process it.

> Source/WebCore/ChangeLog:7
> +	   Need a short description and bug URL (OOPS!)

This will prevent the cq from being able to land this.	the -b option to
prepare-ChangeLog will fill this in automatically for you, or just using
"webkit-patch upload" will fill it in too.