[webkit-reviews] review granted: [Bug 52048] commit-queue should know how to upload archived results (for test flakes or general failures) : [Attachment 78388] Now with workspace.py and much better testing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 11 00:58:29 PST 2011


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 52048: commit-queue should know how to upload archived results (for test
flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048

Attachment 78388: Now with workspace.py and much better testing
https://bugs.webkit.org/attachment.cgi?id=78388&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78388&action=review

Thanks for iterating on this patch.

> Tools/Scripts/webkitpy/common/system/workspace_unittest.py:37
> +    def test_find_unused_filename(self):

No test for make_zip?


More information about the webkit-reviews mailing list