[webkit-reviews] review granted: [Bug 52078] Make Geolocation features work in WebKit2 : [Attachment 78480] Step 2

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 52078: Make Geolocation features work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52078

Attachment 78480: Step 2
https://bugs.webkit.org/attachment.cgi?id=78480&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78480&action=review

> WebKit2/UIProcess/GeolocationPermissionRequestManagerProxy.cpp:43
> +    for (; it != end; ++it)

This should read

for (PendingRequestMap::const_iterator it = m_pendingRequests.begin(), end =
m_pendingRequests.end(); it != end; ++it)

> WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:73
> +    m_idToGeolocationMap.remove(it->second);

Is this allowed? I thought it would be invalidated by the first call to .remove