[webkit-reviews] review granted: [Bug 52178] Remove extraneous COMPILER(GCC) condition when checking GCC_VERSION_AT_LEAST() : [Attachment 78470] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 52178: Remove extraneous COMPILER(GCC) condition when checking
GCC_VERSION_AT_LEAST()
https://bugs.webkit.org/show_bug.cgi?id=52178

Attachment 78470: Patch
https://bugs.webkit.org/attachment.cgi?id=78470&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78470&action=review

Looks good, but pleae double-check the wording in the ChangeLog.

> Source/JavaScriptCore/ChangeLog:11
> +	   It is sufficient to test GCC_VERSION_AT_LEAST() instead of both
COMPILER(GCC) and
> +	   GCC_VERSION_AT_LEAST() as GCC_VERSION_AT_LEAST() is defined only
when we are
> +	   compiling with GCC (i.e. COMPILER(GCC) is true).
> +

Careful with this wording. My reading of this is that GCC_VERSION_AT_LEAST() is
undefined when we aren't on GCC, but in actuality GCC_VERSION_AT_LEAST() is
defined as 0.