[webkit-reviews] review denied: [Bug 52068] Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe : [Attachment 78443] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 52068: Need to consider UNPACK_ALIGNMENT in
GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068

Attachment 78443: Patch
https://bugs.webkit.org/attachment.cgi?id=78443&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78443&action=review

The code changes look good; however, there's a bug in the test case pulled down
from Khronos that needs to be fixed.

> LayoutTests/fast/canvas/webgl/read-pixels-test-expected.txt:1
> +CONSOLE MESSAGE: line 114: ReferenceError: Can't find variable:
INVALID_OPERATION

There's a bug in the test case; the initialization of the various bad tests
isn't picking up the enum values through the WebGLRenderingContext object. An
exception is being thrown, and the test isn't completing successfully.