[webkit-reviews] review canceled: [Bug 51249] [Qt] Extend the Platform Plugin to support full screen video handler : [Attachment 78441] updated with Simon's suggestion (removed default fullscreen widget)

[bugzilla-daemon at webkit.org]

yi shen <yi.4.shen at nokia.com> has canceled yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 51249: [Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249

Attachment 78441: updated with Simon's suggestion (removed default fullscreen
widget)
https://bugs.webkit.org/attachment.cgi?id=78441&action=review

------- Additional Comments from yi shen <yi.4.shen at nokia.com>
I didn't change following function names, one reason is that in
HTMLMeidaElement, it uses enterfullscreen/exitfullscreen. Simon, could you give
some comments for these function name? Still, thank you, Kenneth :-)

> WebKit/qt/Api/qwebkitplatformplugin.h:130
> +    void fullscreenClosed();

What about leftFullscreen. ie, you enter/leave. Maybe Simon has some better
ideas.

> WebKit/qt/Api/qwebkitplatformplugin.h:134
> +    virtual void enterFullscreen(QMediaPlayer*) = 0;
> +    virtual void exitFullscreen() = 0;

leaveFullscreen