[webkit-reviews] review denied: [Bug 51879] [Symbian] Adobe flash Lite plugin on Symbian needs null window quirk : [Attachment 78427] Fixed check-webkit-style issues
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 10 12:16:35 PST 2011
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Leonid Ebril
<leonid.ebril at nokia.com>'s request for review:
Bug 51879: [Symbian] Adobe flash Lite plugin on Symbian needs null window quirk
https://bugs.webkit.org/show_bug.cgi?id=51879
Attachment 78427: Fixed check-webkit-style issues
https://bugs.webkit.org/attachment.cgi?id=78427&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78427&action=review
> Source/WebCore/ChangeLog:8
> + plugin if Flash 10 or newer (for Symbian platform), setting a NULL
s/NULL/nulled/
> Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:58
> + determineQuirks (mime[0]);
no space needed before (
> Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:70
> + static const PlatformModuleVersion flashTenVersion(0x000a0000);
flashVersionTen seems more proper.
> Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:72
> + // Flash 10 doesn't like having a 0 window handle
comments need a dot at the end. ie. be proper sentences.
More information about the webkit-reviews
mailing list