[webkit-reviews] review granted: [Bug 51828] [GTK] Port combo box painting to GtkStyleContext : [Attachment 78422] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 10 12:11:07 PST 2011
Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 51828: [GTK] Port combo box painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51828
Attachment 78422: Patch
https://bugs.webkit.org/attachment.cgi?id=78422&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78422&action=review
r=me
> Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:48
> +using namespace std;
Why is this needed?
PS: Martin says it might be for 'floor'. Better to include whatever is needed
and/or do std::floor instead of doing this for just two calls?
More information about the webkit-reviews
mailing list