[webkit-reviews] review granted: [Bug 52159] [chromium] simplify complex glyph positioning code : [Attachment 78416] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 11:47:23 PST 2011


Tony Chang <tony at chromium.org> has granted Evan Martin <evan at chromium.org>'s
request for review:
Bug 52159: [chromium] simplify complex glyph positioning code
https://bugs.webkit.org/show_bug.cgi?id=52159

Attachment 78416: Patch
https://bugs.webkit.org/attachment.cgi?id=78416&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78416&action=review

> WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp:335
> +    if (isRTL) {
> +	   for (size_t i = 0; i < m_item.num_glyphs; ++i) {
> +	       m_xPositions[i] += width;
>	   }
>      }

Nit: {} are optional.


More information about the webkit-reviews mailing list