[webkit-reviews] review granted: [Bug 52078] Make Geolocation features work in WebKit2 : [Attachment 78292] Step 1

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 52078: Make Geolocation features work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52078

Attachment 78292: Step 1
https://bugs.webkit.org/attachment.cgi?id=78292&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78292&action=review

> WebKit2/WebProcess/Geolocation/WebGeolocationManager.h:47
> +    WebGeolocationManager(WebProcess*);

Please make this explicit.

> WebKit2/WebProcess/WebCoreSupport/WebGeolocationClient.cpp:55
> +{

Should this be implemented?

> WebKit2/WebProcess/WebCoreSupport/WebGeolocationClient.cpp:64
> +{

Should this be implemented?

> WebKit2/WebProcess/WebCoreSupport/WebGeolocationClient.cpp:68
> +{

Should this be implemented?