[webkit-reviews] review denied: [Bug 26232] build options in the build-webkit script are outdated : [Attachment 78386] a patch to update features in build-webkit script

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied ChangSeok Oh
<webkitdeveloper at gmail.com>'s request for review:
Bug 26232: build options in the build-webkit script are outdated
https://bugs.webkit.org/show_bug.cgi?id=26232

Attachment 78386: a patch to update features in build-webkit script
https://bugs.webkit.org/attachment.cgi?id=78386&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78386&action=review

This change doesn’t explain why the options that are being removed from
build-webkit are being removed.  It is also adding a number of options that
don’t appear to map to any underlying feature defines (e.g., they have no
effect). It adds some flags that are of dubious value (e.g., opcode-stats). It
also adds a number of flags that are specific to the GTK build system and in my
mind are not interesting to add to build-webkit (e.g., shared, static,
optimizations, fast-install). If someone wants to customize things to that
degree then they’re better off using ./configure directly.

> Tools/Scripts/build-webkit:115
>	 define => "ENABLE_3D_CANVAS", default => (isAppleMacWebKit() &&
!isTiger() && !isLeopard()), value => \$threeDCanvasSupport },

Command-line options are lowercase by convention.

> Tools/Scripts/build-webkit:118
> +	 define => "ENABLE_3D_TRANSFORMS", default => 0, value =>
\$threeDTransformsSupport },

This change seems bogus. ENABLE_3D_TRANSFORMS is not a feature define that
appears in the source from what I can see.

> Tools/Scripts/build-webkit:148
> +	 define => "ENABLE_FAST_MALLOC", default => 1, value =>
\$fastMallocSupport },

Again, ENABLE_FAST_MALLOC does not appear to correspond to a feature define.