[webkit-reviews] review denied: [Bug 52093] Paste and drag and drop use different code paths to interact with the pasteboard : [Attachment 78300] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 52093: Paste and drag and drop use different code paths to interact with
the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=52093

Attachment 78300: Patch
https://bugs.webkit.org/attachment.cgi?id=78300&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78300&action=review

It seems unfortunate that we have to pass around a Frame* on all platforms
because userVisibleString and canonicalizeURL* are in WebKit/mac.  How much
work is it to move this code into WebCore?

r- just for style and compilation errors.

> WebCore/platform/mac/PasteboardMac.mm:481
> +String Pasteboard::asURL(Frame* frame)
> +{
> +    return [getBestURL(frame) absoluteString];
> +}

Nit: I'm not sure having a helper method provides much benefit here since it's
only called from here.

> WebKit/mac/WebView/WebHTMLView.mm:-1721
> -// keep in sync with WebPasteboardHelper::insertablePasteboardTypes

Should this be updated to say "keep in sync with
WebCore::insertablePasteboardTypes"?  Alternately, would adding this to
EditorClient make it possible to share this code (maybe there's a better place
for it)?