[webkit-reviews] review denied: [Bug 51815] [GTK] Port check and radio button painting to GtkStyleContext : [Attachment 78396] Updated patch using adjustRepaintRect()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 08:52:19 PST 2011


Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 51815: [GTK] Port check and radio button painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51815

Attachment 78396: Updated patch using adjustRepaintRect()
https://bugs.webkit.org/attachment.cgi?id=78396&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78396&action=review

> Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:220
> +    IntRect indicatorRect(rect.x(), rect.y() + ((rect.height() -
indicatorSize) / 2), indicatorSize, indicatorSize);

It seems like ((rect.height() - indicatorSize) / 2) is dead code, so it should
probably be removed.


More information about the webkit-reviews mailing list