[webkit-reviews] review denied: [Bug 30179] [Qt] Need a way to inform the application when a Netscape plugin is created or deleted. : [Attachment 77338] Fixed style error

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 07:10:31 PST 2011


Simon Hausmann <hausmann at webkit.org> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 30179: [Qt] Need a way to inform the application when a Netscape plugin is
created or deleted.
https://bugs.webkit.org/show_bug.cgi?id=30179

Attachment 77338: Fixed style error
https://bugs.webkit.org/attachment.cgi?id=77338&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
As far as I can see only a callback for the _creation_ is needed, so I think it
the deletion callback should be removed (QObject's destroyed signal can be used
instead).

Also I think the changes can be limited to PluginViewSymbian.cpp then. The code
from qwebpage.cpp can move there, too. That way we don't need
#ifdefs for this Symbian specific feature.


More information about the webkit-reviews mailing list