[webkit-reviews] review denied: [Bug 52141] [Chromium] Issue 57432: Layout Test fast/canvas/drawImage-with-negative-source-destination.html failing with --accelerated-2d-canvas : [Attachment 78379] Fix shader program
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 10 01:05:24 PST 2011
Adam Barth <abarth at webkit.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 52141: [Chromium] Issue 57432: Layout Test
fast/canvas/drawImage-with-negative-source-destination.html failing with
--accelerated-2d-canvas
https://bugs.webkit.org/show_bug.cgi?id=52141
Attachment 78379: Fix shader program
https://bugs.webkit.org/attachment.cgi?id=78379&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks for the patch, but all patches need to have a ChangeLog entry that
describes why we're making the change. In the case, you'll want to mention the
test that you're fixing and why we should replace texCoord with gl_TexCoord[0].
This page has more detailed information:
http://webkit.org/coding/contributing.html
More information about the webkit-reviews
mailing list