[webkit-reviews] review denied: [Bug 32509] ITU-T keyboard lacks character echo in web input fields : [Attachment 59086] Latest patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Samuel Nevala
<samuel.nevala at digia.com>'s request for review:
Bug 32509: ITU-T keyboard lacks character echo in web input fields
https://bugs.webkit.org/show_bug.cgi?id=32509

Attachment 59086: Latest patch
https://bugs.webkit.org/attachment.cgi?id=59086&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=59086&action=review

> LayoutTests/editing/input/secure-text.html:56
> +	   eventSender.keyDown("rightArrow");
> +    }

You should probably log("DONE") at the end.

> WebCore/editing/Editor.cpp:1487
> +	      RenderText* textRenderer =
static_cast<RenderText*>(baseNode->renderer());
> +	      if (textRenderer && textRenderer->style() &&
textRenderer->style()->textSecurity() != TSNONE) {
> +		  String originalText = textRenderer->text();
> +		  originalText.replace(baseOffset, text.length(), text);
> +		  textRenderer->setText(originalText.impl());
> +	      }

Why aren't you fixing TypingCommand::insertText instead (e.g. add an argument)?
 It doesn't make much sense to me that you're inserting text, and then
replacing it.  This code may affect selection; e.g. clears selection.

> WebCore/rendering/RenderText.cpp:1098
> +	       if
(!document()->page()->focusController()->focusedOrMainFrame()->editor()->hasCom
position())
> +		   m_text.makeSecure(secureChar);

How do you know that this text node is the one focused?  Or even that m_text is
on the focused frame? r- because of this condition.