[webkit-reviews] review granted: [Bug 52118] In WebKit2, PDF view settings (mode and scale) do not stick : [Attachment 78337] Add support for double-valued preferences; save and restore PDF scale and mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 8 21:58:35 PST 2011


Sam Weinig <sam at webkit.org> has granted mitz at webkit.org's request for review:
Bug 52118: In WebKit2, PDF view settings (mode and scale) do not stick
https://bugs.webkit.org/show_bug.cgi?id=52118

Attachment 78337: Add support for double-valued preferences; save and restore
PDF scale and mode
https://bugs.webkit.org/attachment.cgi?id=78337&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78337&action=review

> WebKit2/UIProcess/API/mac/PDFViewController.mm:134
> +    WebKit::WebPreferences *preferences =
WebKit::toImpl([_pdfViewController->wkView()
pageRef])->pageGroup()->preferences();

The * should be on the other side.  This file should also probably just add
using namespace WebKit to the top if possible.


More information about the webkit-reviews mailing list