[webkit-reviews] review canceled: [Bug 52085] Add Document::setContent() : [Attachment 78280] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has canceled Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 52085: Add Document::setContent()
https://bugs.webkit.org/show_bug.cgi?id=52085

Attachment 78280: Patch
https://bugs.webkit.org/attachment.cgi?id=78280&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #2)
> (From update of attachment 78280 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=78280&action=review
> 
> > WebCore/dom/Document.cpp:1170
> > +bool Document::setContent(const Vector<char>& content)
> 
> Is it really better to have something that takes a vector rather than a const
char*, size_t pair?

No, Vector as argument is a clear mistake.
I think you meant const char*, int pair? (see
http://trac.webkit.org/browser/trunk/Source/WebCore/dom/DocumentParser.h?rev=75
314#L49)