[webkit-reviews] review granted: [Bug 48511] [GTK] Implement Process/Thread Launcher classes and WebProcessGtkMain for WebKit2 : [Attachment 78323] Removed the unnecessary encoding

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 8 11:39:47 PST 2011


Martin Robinson <mrobinson at webkit.org> has granted Amruth Raj
<amruthraj at motorola.com>'s request for review:
Bug 48511: [GTK] Implement Process/Thread Launcher classes and
WebProcessGtkMain for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48511

Attachment 78323: Removed the unnecessary encoding
https://bugs.webkit.org/attachment.cgi?id=78323&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78323&action=review

Thanks!

> WebCore/platform/gtk/FileSystemGtk.cpp:196
> +    return CString(dirname.get());

The CString call isn't strictly necessary here. I'll fix this before landing.

> WebCore/platform/gtk/FileSystemGtk.cpp:204
> +    return CString(dirname.get());

Ditto.


More information about the webkit-reviews mailing list