[webkit-reviews] review denied: [Bug 52075] Don't assert when trying to recompile JS while executing JS : [Attachment 78259] proposed solution

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Benjamin Meyer
<ben at meyerhome.net>'s request for review:
Bug 52075: Don't assert when trying to recompile JS while executing JS
https://bugs.webkit.org/show_bug.cgi?id=52075

Attachment 78259: proposed solution
https://bugs.webkit.org/attachment.cgi?id=78259&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
This won't work.  If you do this, then you'll end up throwing away the code for
functions that are live one the stack.	The code buffer may be reused and
overwritten, and then we may may a return back into that address range
expecting the old code to be there.

Right now we can only handle throwing away code if the machine stack is empty,
WebCore does need to ensure that it only calls this method whilst no JavaScript
execution is taking place.