[webkit-reviews] review granted: [Bug 52086] Make WebKitTestRunner rest between loads more robust to avoid test crashes : [Attachment 78278] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 52086: Make WebKitTestRunner rest between loads more robust to avoid test
crashes
https://bugs.webkit.org/show_bug.cgi?id=52086

Attachment 78278: Patch
https://bugs.webkit.org/attachment.cgi?id=78278&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78278&action=review

If you remove the debug code, this looks fine.	r=me

> Tools/WebKitTestRunner/TestController.cpp:40
> -static const double defaultShortTimeout = 5;
> +static const double defaultShortTimeout = 30;

You should revert this.

> Tools/WebKitTestRunner/TestController.cpp:364
> +    platformRunUntil(done, timeoutDuration == (TimeoutDuration)(-15) ? 3600
: timeoutDuration == ShortTimeout ? m_shortTimeout : m_longTimeout);

This too.

> Tools/WebKitTestRunner/TestInvocation.cpp:135
> +    TestController::shared().runUntil(m_gotFinalMessage,
(TestController::TimeoutDuration)(-13));

Here too.