[webkit-reviews] review granted: [Bug 31273] [Qt][Symbian] Make sure WebKit headers are included before platform headers on Symbian : [Attachment 78284] fix for WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 7 15:39:39 PST 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 31273: [Qt][Symbian] Make sure WebKit headers are included before platform
headers on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31273

Attachment 78284: fix for WebKit2
https://bugs.webkit.org/attachment.cgi?id=78284&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78284&action=review

> WebKit2/WebKit2.pro:168
>  
> +symbian {
> +    PREPEND_INCLUDEPATH = $$WEBKIT2_INCLUDEPATH $$PREPEND_INCLUDEPATH
> +} else {
> +    INCLUDEPATH = $$WEBKIT2_INCLUDEPATH $$INCLUDEPATH
> +}

I think it would be nice with a comment here.


More information about the webkit-reviews mailing list