[webkit-reviews] review granted: [Bug 52018] Adopting an iframe to a child frame results in stack overflow : [Attachment 78269] Added one more test case per Ojan's comment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 7 15:25:24 PST 2011


Ojan Vafai <ojan at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 52018: Adopting an iframe to a child frame results in stack overflow
https://bugs.webkit.org/show_bug.cgi?id=52018

Attachment 78269: Added one more test case per Ojan's comment
https://bugs.webkit.org/attachment.cgi?id=78269&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78269&action=review

What do other browsers do in this case?

> LayoutTests/fast/html/adopt-parent-frame.html:21
> +   
iframe.contentDocument.body.appendChild(iframe.contentDocument.createElement('b
r'));
> +    iframe.style.width = '70%';
> +    iframe.style.height = '40%';

These three lines don't seem useful. Delete them?


More information about the webkit-reviews mailing list