[webkit-reviews] review granted: [Bug 52008] [chromium] fix for animated gif layout tests : [Attachment 78150] Patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has granted Tony Chang
<tony at chromium.org>'s request for review:
Bug 52008: [chromium] fix for animated gif layout tests
https://bugs.webkit.org/show_bug.cgi?id=52008

Attachment 78150: Patch
https://bugs.webkit.org/attachment.cgi?id=78150&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78150&action=review

>>> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1447

>> 
>> Instead of needing a new class, can this use
webkit_support::PostDelayedTask(painInvalidatedRegion,
static_cast<void*>(this), 0); (the way closeWidgetSoon works?)
> 
> I tried that, but it crashes on some tests.  The task is queued up and the
WebViewHost is deleted before the task is run.	TaskList handles this by
canceling the task if WebViewHost goes away.
> 
> http/tests/appcache/crash-when-navigating-away-then-back.html is an example
of a test that triggers this crash.

Would it make sense to retrofit webkit_support::PostDelayedTask to also use a
TaskList so that it's more resilient (beyond the scope of this patch though)?