[webkit-reviews] review granted: [Bug 51957] Provide test cases for testing contentEditable DOM attribute : [Attachment 78239] fix patch 3

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 51957: Provide test cases for testing contentEditable DOM attribute
https://bugs.webkit.org/show_bug.cgi?id=51957

Attachment 78239: fix patch 3
https://bugs.webkit.org/attachment.cgi?id=78239&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78239&action=review

Thanks for the tests!  Few minor things but I'd say r+.

>
LayoutTests/editing/editability/attr-missing-parent-ancestor-missing-expected.t
xt:1
> +When contentEditable is missing, it maps to "inherit" state and the element
is NOT editable if its parent/ancestor's contentEditable is also missing.

Nit: "if contentEditable is never set on all ancestor" might sound better.

> LayoutTests/editing/editability/set-invalid-value-expected.txt:11
> +PASS document.getElementById("div").getAttribute("contentEditable") is "abc"


Should getAttribute return "abc" here?	If the assignment failed, shouldn't it
stay the same?