[webkit-reviews] review denied: [Bug 52068] Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe : [Attachment 78250] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 52068: Need to consider UNPACK_ALIGNMENT in
GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068

Attachment 78250: Patch
https://bugs.webkit.org/attachment.cgi?id=78250&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78250&action=review

> WebCore/platform/graphics/GraphicsContext3D.cpp:138
> +	   getIntegerv(GraphicsContext3D::UNPACK_ALIGNMENT, &unpackAlignment);

This query will kill performance of texture uploads. Instead, change the
function signature and all callers to pass in the current unpack alignment, or
track the unpack alignment in the GraphicsContext3D implementation.