[webkit-reviews] review granted: [Bug 51941] refactor HTMLLinkElement to allow Link header implementation : [Attachment 78248] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 51941: refactor HTMLLinkElement to allow Link header implementation
https://bugs.webkit.org/show_bug.cgi?id=51941

Attachment 78248: Patch
https://bugs.webkit.org/attachment.cgi?id=78248&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78248&action=review

This looks great.  Some extremely minor nits below.  I look forward to the next
patch.	:)

> WebCore/WebCore.xcodeproj/project.pbxproj:-22334
> -			developmentRegion = English;

Probably better not to fight the developmentRegion war.

> WebCore/html/HTMLLinkElement.h:60
> +    //    bool isIcon() const { return m_relAttribute.m_isIcon; }

Please remove commented out code.

> WebCore/html/HTMLLinkElement.h:77
> +

extra blank line.

> WebCore/loader/LinkLoaderClient.h:37
> +

extra space