[webkit-reviews] review granted: [Bug 52051] [GTK] Port scrollbar painting to GtkStyleContext : [Attachment 78218] Use GtkStyleContext API to paint scrollbars

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 52051: [GTK] Port scrollbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52051

Attachment 78218: Use GtkStyleContext API to paint scrollbars
https://bugs.webkit.org/attachment.cgi?id=78218&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78218&action=review

Great. Please fix the two minor issues before landing this.

> WebCore/platform/gtk/ScrollbarThemeGtk3.cpp:46
> +    m_context =
static_cast<RenderThemeGtk*>(RenderTheme::defaultTheme().get())->gtkScrollbarSt
yle();

You should use a an initialization field here.
ScrollbarThemeGtk::ScrollbarThemeGtk()
    :
m_context(static_cast<RenderThemeGtk*>(RenderTheme::defaultTheme().get())->gtkS
crollbarStyle())

> WebCore/platform/gtk/ScrollbarThemeGtk3.cpp:53
> +    gtk_style_context_get_style(m_context,

I think we should ASSERT(m_context) before here.