[webkit-reviews] review granted: [Bug 50254] Canceled frame loads can corrupt back forward list : [Attachment 78246] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 7 10:18:43 PST 2011
Mihai Parparita <mihaip at chromium.org> has granted Charles Reis
<creis at chromium.org>'s request for review:
Bug 50254: Canceled frame loads can corrupt back forward list
https://bugs.webkit.org/show_bug.cgi?id=50254
Attachment 78246: Patch
https://bugs.webkit.org/attachment.cgi?id=78246&action=review
------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78246&action=review
You should also rebaseline your patch against ToT, otherwise the commit queue
may have trouble landing your change (at least the review tool can't apply your
changes to FrameLoader.cpp to tip of tree).
> WebCore/loader/HistoryController.cpp:657
> + // Note: Some clients treat a navigatation to the current history item
as
Typo (navigatation)
More information about the webkit-reviews
mailing list