[webkit-reviews] review granted: [Bug 51559] copyTexSubImage2D shouldn't have undefined pixels : [Attachment 78243] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 51559: copyTexSubImage2D shouldn't have undefined pixels
https://bugs.webkit.org/show_bug.cgi?id=51559

Attachment 78243: Patch
https://bugs.webkit.org/attachment.cgi?id=78243&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78243&action=review

Looks good - one minor issue with the new code which can be fixed upon landing.


> WebCore/html/canvas/WebGLRenderingContext.cpp:752
> +	       if (zero.get())

This can just be if (zero). These pointer types have an operator which converts
to boolean type.

> WebCore/html/canvas/WebGLRenderingContext.cpp:755
> +	       if (zero.get())

Here too.