[webkit-reviews] review requested: [Bug 51932] GTK: AX: atk tests need to be updated after recent changes : [Attachment 78242] Patch proposal (change gtk_widget_get_accessible in WebKitWebView + fix bottom up navigation)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 7 09:16:39 PST 2011
Mario Sanchez Prada <msanchez at igalia.com> has asked for review:
Bug 51932: GTK: AX: atk tests need to be updated after recent changes
https://bugs.webkit.org/show_bug.cgi?id=51932
Attachment 78242: Patch proposal (change gtk_widget_get_accessible in
WebKitWebView + fix bottom up navigation)
https://bugs.webkit.org/attachment.cgi?id=78242&action=review
------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a new patch, this time seriously asking for revision after having
checked with Joanmarie Diggs a couple of issues I was missing before (bottom up
navigation through the get_parent() method), and confirming that returning the
WebArea object when calling gtk_widget_get_accessible(webView) is the right
thing to do (opposite to returning the scrollArea).
The patch also unskip the tests, I guess it's fine that way.
More information about the webkit-reviews
mailing list