[webkit-reviews] review requested: [Bug 50869] [cairo] Rendering a lot of arcs on top of each other causes time outs in some tests : [Attachment 78225] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 7 05:39:53 PST 2011
Alejandro G. Castro <alex at igalia.com> has asked for review:
Bug 50869: [cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869
Attachment 78225: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=78225&action=review
------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
I made a mistake checking the performance of the solution, we can do it without
the modff. This patch avoids using modff to avoid precision errors.
Not sure why in Qt solution they do not pay attention to the end angle in this
situation, maybe it is a bug, and in case of skia they do not use anticlockwise
property, which could cause issues with fill rules AFAIK.
More information about the webkit-reviews
mailing list