[webkit-reviews] review denied: [Bug 52020] Member variables do not begin with m_ in QPageClientWidgetQt and QPageClientGraphicsWidgetQt : [Attachment 78176] Proposed Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Carol Szabo
<carol.szabo at nokia.com>'s request for review:
Bug 52020: Member variables do not begin with m_ in QPageClientWidgetQt and
QPageClientGraphicsWidgetQt
https://bugs.webkit.org/show_bug.cgi?id=52020

Attachment 78176: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=78176&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78176&action=review

The general rule is that public member variables don't have an "m_" prefix.
You could make them private and add setters/getters as needed.

> WebKit/qt/WebCoreSupport/PageClientQt.h:58
> -	   : view(newView)
> -	   , page(newPage)
> +	   : m_view(newView)
> +	   , m_page(newPage)
>  #if USE(ACCELERATED_COMPOSITING) && USE(TEXTURE_MAPPER)
>	   , syncTimer(this, &PageClientQWidget::syncLayers)
>	   , platformLayerProxy(0)
>  #endif

Looks like you missed 'syncTimer' and 'platformLayerProxy'.