[webkit-reviews] review requested: [Bug 51382] [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field. : [Attachment 78213] Eliminate layout() call from calculateWidgetRect() and change the name to layoutOrCalculateWidgetRect()

[bugzilla-daemon at webkit.org]

Ilya Sherman <isherman at chromium.org> has asked	for review:
Bug 51382: [Chromium] Fix popup menu re-positioning when the menu is opened
upward, above the corresponding form field.
https://bugs.webkit.org/show_bug.cgi?id=51382

Attachment 78213: Eliminate layout() call from calculateWidgetRect() and change
the name to layoutOrCalculateWidgetRect()
https://bugs.webkit.org/attachment.cgi?id=78213&action=review

------- Additional Comments from Ilya Sherman <isherman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78213&action=review

You should set "r: ?" and "cq: ?" for patches that you'd like reviewed --
setting "r: -" means that the review has been denied.

> WebCore/platform/chromium/PopupMenuChromium.cpp:332
> +IntRect PopupContainer::layoutOrCalculateWidgetRect()

nit: Since you don't call layout() within this function, the name
calculateWidgetRect() is more appropriate.  I think you read Kent's "and -> or"
comment as applying to the wrong "and" ;)