[webkit-reviews] review requested: [Bug 52044] REGRESSION(r74807): No-cache is ignored within a document : [Attachment 78207] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 6 21:22:58 PST 2011


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 52044: REGRESSION(r74807): No-cache is ignored within a document
https://bugs.webkit.org/show_bug.cgi?id=52044

Attachment 78207: proposed fix
https://bugs.webkit.org/attachment.cgi?id=78207&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I'm not sure if this patch is technically correct. We also had some URL checks
prior to r74807, which moved them, and changed their meaning. But all HTTP
regression tests pass.

Also, I don't really understand what changed in this revision to make similar
code so different. It's possible that there are other regressions I don't know
about. I only learned about this particular behavior change because Antti
mentioned it in bug 43704 comment 23.


More information about the webkit-reviews mailing list