[webkit-reviews] review denied: [Bug 50901] Add remote zip file handling to webkitpy. : [Attachment 78201] Patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has denied James Kozianski
<koz at chromium.org>'s request for review:
Bug 50901: Add remote zip file handling to webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=50901

Attachment 78201: Patch
https://bugs.webkit.org/attachment.cgi?id=78201&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78201&action=review

> Tools/Scripts/webkitpy/common/system/filesystem.py:162
> +    def extract(self, zip, filename, path):

As discussed in #webkit, extract doesn't really belong in FileSystem. For the
sake of testability, passing in the ZipFile (or a lazy-loading wrapper) to the
ZipFileSet constructor is cleaner.

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:60
> +	   return os.path.join(*comps)

The mock filesystem hardcodes / as the separator, so it should keep using
'/'.join(comps) as its join() implementation.