[webkit-reviews] review granted: [Bug 50254] Canceled frame loads can corrupt back forward list : [Attachment 78175] Patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has granted Charles Reis
<creis at chromium.org>'s request for review:
Bug 50254: Canceled frame loads can corrupt back forward list
https://bugs.webkit.org/show_bug.cgi?id=50254

Attachment 78175: Patch
https://bugs.webkit.org/attachment.cgi?id=78175&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78175&action=review

> WebCore/loader/HistoryController.cpp:657
> +    // Note: If item1 and item2 are the same, then we need to create a new

This comment (which I realize predates your patch, you just moved it around)
always bothered me, since it's just stating what the code does, but doesn't
explain why that behavior is desired/necessary.  Based on
http://webkit.org/b/35532 (which is the oldest reference to it that I can
find), it seems like some WebKit clients use navigation to the current history
item as a reload mechanism. Perhaps you can mention that (and/or the bug
number) so that the comment provides some justification for the behavior?