[webkit-reviews] review granted: [Bug 45557] Define GC3D types to match GL types and use them in GraphicsContext3D : [Attachment 78190] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 45557: Define GC3D types to match GL types and use them in
GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=45557

Attachment 78190: Patch
https://bugs.webkit.org/attachment.cgi?id=78190&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78190&action=review

Thanks for doing this tedious cleanup. It will ease maintenance of this code in
the future. Only one tiny issue, can be fixed upon landing.

> WebCore/platform/graphics/GraphicsContext3D.h:722
> +    // FIXME: change the argument orders to match OpenGL's.

This FIXME should actually be moved above the call of uniform1f. All of the
uniform*v entry points have the wrong argument order.