[webkit-reviews] review denied: [Bug 48459] Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows : [Attachment 77702] A patch to make WebKit Windows render vertical text correctly

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Chun-Lung Huang
<alvincl.huang at gmail.com>'s request for review:
Bug 48459: Glyphs in vertical text tests are rotated 90 degrees clockwise on
Windows
https://bugs.webkit.org/show_bug.cgi?id=48459

Attachment 77702: A patch to make WebKit Windows render vertical text correctly
https://bugs.webkit.org/attachment.cgi?id=77702&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
If I'm understanding this correctly, you're just putting @ in front of the
family name to get the fonts hashed separately to trip the broken ideographic
font code path.  That isn't really supporting vertical text.  Punctuation
glyphs won't be correct for example.

I would prefer orientation just be part of the constructed hash key rather than
hacking the family name.  We have to do this with bold and oblique already, so
I think that's a better approach than hacking the family name.

Even once you do this, though, you're only sort of supporting vertical text
here.  The simple code path is using the broken ideographic font code, which
won't really use vertical glyphs from a font with vertical tables (like
punctuation glyphs), and the complex code path (that uses Uniscribe) isn't
doing anything either.