[webkit-reviews] review denied: [Bug 49388] Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations : [Attachment 78154] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 6 14:04:08 PST 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 49388: Share code between Mac (CA) and Windows (CACF) GraphicsLayer
implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Attachment 78154: Patch
https://bugs.webkit.org/attachment.cgi?id=78154&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78154&action=review

This all looks fine, but reflections aren't working because layerDidDisplay
isn't being called on Windows, as we discussed.

> WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:916
> -	   for (size_t i = 0; i < newSublayers.size(); ++i)
> +	   for (int i = newSublayers.size() - 1; i >= 0; --i)
>	       newSublayers[i]->removeFromSuperlayer();

Why the order reversal?

> WebCore/platform/graphics/ca/GraphicsLayerCA.h:67
> +    // PlatformCALayerClient overrides
> +    virtual void platformCALayerLayoutSublayersOfLayer(PlatformCALayer*) { }

> +    virtual bool platformCALayerRespondsToLayoutChanges() const { return
false; }
> +
> +    virtual void platformCALayerAnimationStarted(CFTimeInterval beginTime);
> +    virtual CompositingCoordinatesOrientation
platformCALayerContentsOrientation() const { return contentsOrientation(); }
> +    virtual void platformCALayerPaintContents(GraphicsContext& context,
const IntRect& clip) { paintGraphicsLayerContents(context, clip); }
> +    virtual bool platformCALayerShowDebugBorders() const { return
showDebugBorders(); }
> +    virtual bool platformCALayerShowRepaintCounter() const { return
showRepaintCounter(); }
> +    virtual int platformCALayerIncrementRepaintCount() { return
incrementRepaintCount(); }
> +
> +    virtual bool platformCALayerContentsOpaque() const { return
contentsOpaque(); }
> +    virtual bool platformCALayerDrawsContent() const { return
drawsContent(); }
> +    virtual void platformCALayerLayerDidDisplay(PlatformLayer* layer) {
return layerDidDisplay(layer); }

Please make these private.

> WebCore/platform/graphics/ca/PlatformCALayerClient.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

2011!


More information about the webkit-reviews mailing list