[webkit-reviews] review granted: [Bug 51996] Windows bots need to archive/unarchive builds to/from configuration-specific directories : [Attachment 78153] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 51996: Windows bots need to archive/unarchive builds to/from
configuration-specific directories
https://bugs.webkit.org/show_bug.cgi?id=51996

Attachment 78153: Patch
https://bugs.webkit.org/attachment.cgi?id=78153&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78153&action=review

> Tools/BuildSlaveSupport/built-product-archive:122
> +	   os.mkdir(configurationBuildDirectory)

Why didn't we need this mkdir before?

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:207
> +	   if platform == "win":
> +	       rootArgument = ['--root=WebKitBuild/' +
self.getProperty('configuration') + '/bin']
> +	   else:
> +	       rootArgument = ['--root=WebKitBuild/bin']

Seems like we should be using os.path.join here, even though we weren't using
it before.

I'm surprised that WebKitBuild/bin is really what we want on non-Windows
platforms. I know that's what we had before, though.