[webkit-reviews] review denied: [Bug 51996] Windows bots need to archive/unarchive builds to/from configuration-specific directories : [Attachment 78132] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 51996: Windows bots need to archive/unarchive builds to/from
configuration-specific directories
https://bugs.webkit.org/show_bug.cgi?id=51996

Attachment 78132: Patch
https://bugs.webkit.org/attachment.cgi?id=78132&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78132&action=review

> Tools/BuildSlaveSupport/built-product-archive:65
>	   configurationBuildDirectory = os.path.join(buildDirectory,
configuration.title())
>	   return subprocess.call(["ditto", "-c", "-k", "--keepParent",
"--sequesterRsrc", configurationBuildDirectory, archiveFile])
>      elif platform == 'win':
> -	   binDirectory = os.path.join(buildDirectory, "bin")
> +	   binDirectory = os.path.join(buildDirectory, configuration.title(),
"bin")

Can you pull the configurationBuildDirectory definition out a level so that we
can use it in the "win" case?

> Tools/BuildSlaveSupport/built-product-archive:123
> +	   configurationBuildDirectory = os.path.join(buildDirectory,
configuration.title())

This is duplicating code that already exists in the "mac" case. Can you share
it?

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:209
> +	   if platform == "win":
> +	       rootArgument = ['--root=WebKitBuild/' +
self.getProperty('configuration') + '/bin']
> +	   else:
> +	       rootArgument = ['--root=WebKitBuild/bin']
>	   if self.skipBuild:
> -	       self.setCommand(self.command + ['--root=WebKitBuild/bin'])
> +	       self.setCommand(self.command + rootArgument)

Why don't we need to do this for RunWebKitTests.start, too?